Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Message table rotation #382

Closed
data-sync-user opened this issue May 30, 2023 · 2 comments
Closed

Remove Message table rotation #382

data-sync-user opened this issue May 30, 2023 · 2 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

With our new metric from release 1.67.1 we’ve determined the number of message table migrations still occurring. It’s a number higher than we’d expect (numerous migrations per day) but still a reasonable number to where we can disable the migrations, instead deleting (resetting) the user’s uaid/subscriptions.

Re-reviewing the Rust version of autoendpoint, it’s effectively already been doing this user reset (instead of migrating) but only upon reception of a notification.

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

A panel showing message table rotations occurring infrequently:

https://earthangel-b40313e5.influxcloud.net/d/do4mmwcVz/autopush-gcp?orgId=1&refresh=1m&from=now-7d&to=now&viewPanel=67 ( https://earthangel-b40313e5.influxcloud.net/d/do4mmwcVz/autopush-gcp?orgId=1&refresh=1m&from=now-7d&to=now&viewPanel=67 )

These only occur when users have a valid current_month contained in a small list of message tables (the current a couple from the previous months).

Additionally we also expire (delete) users who have a current_month older than those in that small list, these also occur infrequently:

https://earthangel-b40313e5.influxcloud.net/d/do4mmwcVz/autopush-gcp?orgId=1&refresh=1m&from=now-7d&to=now&viewPanel=63 ( https://earthangel-b40313e5.influxcloud.net/d/do4mmwcVz/autopush-gcp?orgId=1&refresh=1m&from=now-7d&to=now&viewPanel=63 )

(autopush.ua.expiration.mean w/ {code: 105})

Removing the message table rotation code will cause these users to be dropped instead (same as the latter’s logic).

@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

Closed as part of #364 ( #364 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants