-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or delete idswitch #878
Labels
Milestone
Comments
For me my last hack was only to generate the new code. I think we can drop the idswitch tool and the generator hints from the code. |
"Deleted code is debugged code." – Jeff Sickel |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ref. #863
Use
./gradlew spotlessApply
.before:
after:
In the case of after:,
idswitch
does not seem to find theId_constructor
.https://github.com/mozilla/rhino/tree/0c05d30e134aed65b9c3536d8ac3764590840a35/toolsrc/org/mozilla/javascript/tools/idswitch
ref. #847
Since
findPrototypeId
is now a string switch, I don't see much advantage in usingidswitch
in the future, should I modify it?The text was updated successfully, but these errors were encountered: