Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or delete idswitch #878

Closed
tuchida opened this issue May 2, 2021 · 2 comments
Closed

Fix or delete idswitch #878

tuchida opened this issue May 2, 2021 · 2 comments

Comments

@tuchida
Copy link
Contributor

tuchida commented May 2, 2021

ref. #863
Use ./gradlew spotlessApply.

before:

    private static final int
            Id_constructor = 1,

after:

    private static final int Id_constructor = 1,

In the case of after:, idswitch does not seem to find the Id_constructor.
https://github.com/mozilla/rhino/tree/0c05d30e134aed65b9c3536d8ac3764590840a35/toolsrc/org/mozilla/javascript/tools/idswitch

ref. #847
Since findPrototypeId is now a string switch, I don't see much advantage in using idswitch in the future, should I modify it?

@rbri
Copy link
Collaborator

rbri commented May 2, 2021

For me my last hack was only to generate the new code. I think we can drop the idswitch tool and the generator hints from the code.

@rbri
Copy link
Collaborator

rbri commented May 8, 2021

"Deleted code is debugged code." – Jeff Sickel

@tuchida tuchida closed this as completed Jun 1, 2021
@p-bakker p-bakker added this to the Release 1.7.14 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants