Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong option for nginx modern and intermediate #34

Closed
MagicChocoRolls opened this issue Jul 2, 2019 · 6 comments
Closed

wrong option for nginx modern and intermediate #34

MagicChocoRolls opened this issue Jul 2, 2019 · 6 comments

Comments

@MagicChocoRolls
Copy link

When creating an nginx config, for intermediate and modern the generator always tells me to set ssl_prefer_server_ciphers off;.
This seems weird. I would assume this should always be set to 'on'!?

@april
Copy link
Contributor

april commented Jul 2, 2019

Nope, it should be off for Intermediate and Modern. We talk about why this is here:

https://wiki.mozilla.org/Security/Server_Side_TLS

@april april closed this as completed Jul 2, 2019
@teward
Copy link

teward commented Jul 20, 2019

@april erm... if you DO talk about this in that document, it's not clear where it's stated.

Also, current version of the document as of right now (last rev: 18 days ago) says this:

The ordering of cipher suites in the Intermediate and Old configurations is very important, as it determines the priority with which algorithms are selected.

... which means for Intermediate, ordering is still necessary. Which means your documentation and the generator are in disagreement.

THEREFORE

One of the following must happen:

  1. DETAILED documentation and more clearly visible explanation as to why prefer server ciphers should be off for Intermediate (implied to be off for Modern), and the quoted wording earlier on in the document updated, or

  2. The generator for Intermediate needs to be altered to have ssl_prefer_server_ciphers on;

@april
Copy link
Contributor

april commented Jul 22, 2019

Ahh, it's just the wiki that's off. I'll remove the Intermediate bit from it. Thanks.

@april
Copy link
Contributor

april commented Jul 22, 2019

There, all fixed. :)

@april
Copy link
Contributor

april commented Jul 22, 2019

It should be noted that the JSON document and Intermediate section (in multiple places) talk about why Client Ordered is preferred, it was just that paragraph at the top was incorrect.

The generator has always been correct.

@gene1wood
Copy link
Collaborator

@april thanks for fixing the wiki with mozilla/server-side-tls#262 and @teward thanks so much for catching this inconsistency that was likely to trip up other people as well.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants