This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #2375 Fixes #2564 Improve notification visibility #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
v9/occluded_notifications
branch
from
0ee849f
to
9d6de40
Compare
keianhzo
changed the title
bluemarvin
reviewed
Jan 23, 2020
keianhzo
force-pushed
the
v9/occluded_notifications
branch
from
9d6de40
to
24452ed
Compare
|
Rebase issues fixed. |
bluemarvin
approved these changes
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2375 Fixes #2564 This PR addresses the referenced issues and also refactors the current notification code and exposes a NotificationManager for an easier centralized notification management.