-
Notifications
You must be signed in to change notification settings - Fork 217
Conversation
How do I get the what's new button to show in the navigation bar? |
@bluemarvin I've updated the PR. You should see the what's new icon in the URL bar every time you run FxR from AS as it generates a new version code. Subsequent runs from the Oculus Library shouldn't show it. |
So it looks like the first time FxR is run and the setting
Actual: Expected: |
@bluemarvin fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be better to key off the URL for what's new instead of the version number. That way if we have a dot release and don't updated the what's new url, the button isn't shown again?
@bluemarvin I thought we wanted what's new for every release. If we don't we might need to do some manual update based what's new like what you proposed but we will need to remember to always update the URL whenever we want the button to be shown. |
My concern is we aren't great at updating what is new. So would rather we only show the button when we actually have something new to show and I don't really want to show the button for dot releases since bug fixes really aren't worth the users time. I guess ideally it would dynamically check but that probably too much effort for this issue. |
@bluemarvin An alternative would be to only show the button for major releases and leave out the dot releases. Would that be a good compromise? |
Show what's new on first run
@bluemarvin @Softvision-RemusDranca I've updated the PR with the new flow. Now we user a romote JSON to show/hide the What's new button. The remote properties JSON lives in https://mixedreality.mozilla.org/FirefoxReality/props.json (at least until we have a app specific backend for FxR). This JSON would contain any remote properties that we would want to sync with the app in a dictionary by version. At the moment the only property is the What's New URL. The app will sync the remote properties at startup, if the remote properties cannot be retrieved the cached ones are used (if existing), otherwise the remote ones will be persisted locally. In any case when the remote properties are updated, any consumers will be notified. QA: When should What's New be displayed?
|
@keianhzo I have some follow-up questions regarding the behavior:
|
Only the navigation bar should dissappear, the Settings one should stay but without the badge.
No, there is only one URL per version.
We can show What's New for any version the only condition is that the app version matches one in the JSON file, it can be a major or a dot. |
I have verified this feature with multiple builds installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets. Every issue found was logged, fixed and verified. |
Based on: https://trello.com/c/dzS3HOql/559-uis-97-whats-new-experienceimplementation