This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Closes #3269 Adds Tooltips to the video controls #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Video control tool tips should not be curved when there are multiple windows. Should be handled the same as the tray and have The fullscreen video UI has the same problem: |
bluemarvin
suggested changes
Jun 22, 2020
|
I wonder if it would be easier to make tool tips flat by default and only make them curved for the navbar? |
keianhzo
force-pushed
the
v11/media_controls_tooltips
branch
from
62445c7
to
7113f81
Compare
|
@bluemarvin updated to be flat by default and only curve navigation bar tooltips. Also added a tooltipCurved property to set it in the layout XML. |
keianhzo
force-pushed
the
v11/media_controls_tooltips
branch
from
7113f81
to
bbde39e
Compare
|
@bluemarvin Updated. Now by default the parent's curved mode is used unless a |
bluemarvin
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3269 Adds tooltips to the video controls. Also adds support for curved tooltips, it seems it was lost in some rebase.