This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Lazily initialize GeckoWebExecutor #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
changed the title
MortimerGoro
force-pushed
the
v11/lazy_gecko_web_executor
branch
from
c6632d3
to
6fe307d
Compare
MortimerGoro
force-pushed
the
v11/lazy_gecko_web_executor
branch
from
6fe307d
to
175ae34
Compare
|
Also fixes #3651 |
|
I added a extra workaround for the GeckoResult initialization problem. The lazy initialization should be enough but calling Looper.getMainLooper().getThread() is also a working workaround. Better be safe than sorry... @daoshengmu could you check that telemetry works as expected? |
bluemarvin
approved these changes
Jul 8, 2020
daoshengmu
approved these changes
Jul 8, 2020
keianhzo
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3652
GeckoWebExecutor creation is creating the Gecko runtime and vrPrefsWorkaround must be executed before creating the runtime. Note that vrPrefsWorkaround uses the activity intent to check some extra banchmarking/testing params so we can't run that on the VRApplicationClass (We can't get the activity intent on that stage AFAIK)