NodeMaterial doesn't always recompile

[njarraud]

Description of the problem

NodeMaterial is only recompiled the first time the needsUpdate flag is set to true if the WebGL program cache key doesn't change. I believe that this is due to the fact that now material recompiling is based on version and not only on this needsUpdate flag.

To fix this issue, onBeforeCompile.toString method of NodeMaterial shall return the material version instead of the needsCompile flag. It will force programCacheKey to be different and therefore the material will recompile as requested by the needsUpdate flag.

this.onBeforeCompile.toString = function () {

    return self.version

};

Three.js version

• Dev

Browser

• All of them

OS

• All of them

\ping @sunag

[sunag]

It will force programCacheKey to be different and therefore the material will recompile as requested by the needsUpdate flag.

It can be a problem if the proposal is to share the same shader program with other materials.

Do you already try to add needsCompile = false after the build?

this.onBeforeCompile = function ( shader, renderer ) {

		var materialProperties = renderer.properties.get( this );

		if ( this.version !== materialProperties.__version ) {

			this.build( { renderer: renderer } );

			shader.uniforms = this.uniforms;
			shader.vertexShader = this.vertexShader;
			shader.fragmentShader = this.fragmentShader;

			this.needsCompile = false;

		}

	};

[njarraud]

No, that doesn't work.

[rclankhorst]

this.onBeforeCompile = function ( shader, renderer ) {

		var materialProperties = renderer.properties.get( this );

		if ( this.version !== materialProperties.__version ) {

			this.build( { renderer: renderer } );

			shader.uniforms = this.uniforms;
			shader.vertexShader = this.vertexShader;
			shader.fragmentShader = this.fragmentShader;

			this.needsCompile = false;

		}

	};

This change worked for r111 and r112, but is no longer sufficient for r113.
The line changed by @njarraud does produce a fix.

[rclankhorst]

/ping @sunag Any ideas? I don't feel like making a PR for something potentially troublesome.

[sunag]

@njarraud @rclankhorst You can test now with the current dev state of the threejs?

[Mugen87]

Should be fixed via #19833.

I think it's okay to close this one. It can be reopened if there are still recompilation issues with r119.