From 778040e0f3fb76b6593963f3d90218a91014aaa4 Mon Sep 17 00:00:00 2001 From: Mohammad Saleh Fadaei Date: Sun, 7 Nov 2021 10:28:51 +0330 Subject: [PATCH] refactor: use better errors message --- src/runners/parallel-tasks-runner.ts | 2 +- src/runners/pipeline-tasks-runner.ts | 4 ++-- src/runners/serial-tasks-runner.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/runners/parallel-tasks-runner.ts b/src/runners/parallel-tasks-runner.ts index 32f0508..7187a8d 100644 --- a/src/runners/parallel-tasks-runner.ts +++ b/src/runners/parallel-tasks-runner.ts @@ -26,7 +26,7 @@ export class ParallelTasksRunner extends BaseTasksRunner { public get(index: number): Promise { if (this.status === "open") { - return Promise.reject(new Error("Task runner is open")); + return Promise.reject(new Error("Task runner not yet started")); } // show error if the index is out of bounds diff --git a/src/runners/pipeline-tasks-runner.ts b/src/runners/pipeline-tasks-runner.ts index a1d958f..33cf80c 100644 --- a/src/runners/pipeline-tasks-runner.ts +++ b/src/runners/pipeline-tasks-runner.ts @@ -76,7 +76,7 @@ export class PipelineTasksRunner extends BaseTasksRunner { public async get(index: number): Promise { if (this.status === "open") { - return Promise.reject(new Error("Task runner is open")); + return Promise.reject(new Error("Task runner is not yet started")); } // show error if the index is out of bounds @@ -98,7 +98,7 @@ export class PipelineTasksRunner extends BaseTasksRunner { const nextTask = taskIterator.next(lastResult); lastResult = await nextTask.value; } catch { - return Promise.reject(new Error("Task not reached")); + return Promise.reject(new Error("Task failed before reach")); } } diff --git a/src/runners/serial-tasks-runner.ts b/src/runners/serial-tasks-runner.ts index 1491157..3fe81f4 100644 --- a/src/runners/serial-tasks-runner.ts +++ b/src/runners/serial-tasks-runner.ts @@ -59,7 +59,7 @@ export class SerialTasksRunner extends BaseTasksRunner { public async get(index: number): Promise { if (this.status === "open") { - return Promise.reject(new Error("Task runner is open")); + return Promise.reject(new Error("Task runner is not yet started")); } // show error if the index is out of bounds @@ -80,7 +80,7 @@ export class SerialTasksRunner extends BaseTasksRunner { const nextTask = taskIterator.next() await nextTask.value; } catch { - return Promise.reject(new Error("Task not reached")); + return Promise.reject(new Error("Task failed before reach")); } }