Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry-dynamic-versioning breaks functionality of some poetry commands (e.g. poetry add, poetry remove) which modify pyproject.toml #3

Closed
lmoretto opened this issue Nov 28, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@lmoretto
Copy link

lmoretto commented Nov 28, 2019

Hi,
when poetry-dynamic-versioning is enabled for a project, some poetry commands do not work as expected.

For instance, the expected result of poetry add <dependency> or poetry remove <dependency> commands is to modify the content of pyproject.toml file with the new/removed package dependencies.

I think the reason is that, upon deactivation, poetry-dynamic-versioning completely restores the original contents of pyproject.toml, thus discarding any legitimate modifications to the file performed by poetry.

Would it make sense to only restore the original version field, and keep any other modifications?
If so, I can provide a PR for this.

Thanks and best regards,
Luca

@mtkennerly
Copy link
Owner

Thanks for reporting this! Yes, I think just restoring the version field would be the right way to go. A PR would absolutely be welcome if you're interested.

@mtkennerly
Copy link
Owner

The fix for this is now available in release v0.3.1.

@mtkennerly mtkennerly added the bug Something isn't working label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants