You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
when poetry-dynamic-versioning is enabled for a project, some poetry commands do not work as expected.
For instance, the expected result of poetry add <dependency> or poetry remove <dependency> commands is to modify the content of pyproject.toml file with the new/removed package dependencies.
I think the reason is that, upon deactivation, poetry-dynamic-versioning completely restores the original contents of pyproject.toml, thus discarding any legitimate modifications to the file performed by poetry.
Would it make sense to only restore the original version field, and keep any other modifications?
If so, I can provide a PR for this.
Thanks and best regards,
Luca
The text was updated successfully, but these errors were encountered:
Thanks for reporting this! Yes, I think just restoring the version field would be the right way to go. A PR would absolutely be welcome if you're interested.
Hi,
when poetry-dynamic-versioning is enabled for a project, some poetry commands do not work as expected.
For instance, the expected result of
poetry add <dependency>
orpoetry remove <dependency>
commands is to modify the content ofpyproject.toml
file with the new/removed package dependencies.I think the reason is that, upon deactivation, poetry-dynamic-versioning completely restores the original contents of
pyproject.toml
, thus discarding any legitimate modifications to the file performed by poetry.Would it make sense to only restore the original version field, and keep any other modifications?
If so, I can provide a PR for this.
Thanks and best regards,
Luca
The text was updated successfully, but these errors were encountered: