Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Uncheck SelectAll Checkbox doesn't trigger onRowSelection event #2019

Closed
HaoliangXu opened this issue Oct 31, 2015 · 6 comments
Closed
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!

Comments

@HaoliangXu
Copy link

In a Table component, Uncheck SelectAll Checkbox doesn't trigger any event. And right after Uncheck it, if you tap the checkbox of any row, onRowSelection event passes an array ending with 'undefined' item.

30a7973a-2e00-4cfb-ac04-bfc86e0fd815

@HaoliangXu HaoliangXu changed the title [Table] Uncheck SelectAll Checkbox doesn't trigger any event [Table] Uncheck SelectAll Checkbox doesn't trigger onRowSelection event Oct 31, 2015
@oliviertassinari
Copy link
Member

Is #1609 solving your issue?

@HaoliangXu
Copy link
Author

IMHO it's better to return an array no matter they are all selected or all unselected. But return 'none' is better than nothing.
And there's another issue described in my op, after uncheck the "select all" checkbox, if you tap a checkbox of any row, you get an array ending with "undefined", just like the pic above.

@oliviertassinari
Copy link
Member

I have merge the latest PR. I have also noticed the second issue.
I don't really know how the table is working, do you want to submit a PR to fix it?

@HaoliangXu
Copy link
Author

Sorry, I am just a casual developer. I don't understand what PR is. 😝 But I do think that is a bug.

@alitaheri alitaheri added the bug 🐛 Something doesn't work label Dec 9, 2015
@oliviertassinari oliviertassinari added component: table This is the name of the generic UI component, not the React module! and removed component: table This is the name of the generic UI component, not the React module! labels Dec 18, 2016
@max-b
Copy link

max-b commented May 15, 2017

@oliviertassinari I believe this has been fixed. You can see the behavior here:
https://www.webpackbin.com/bins/-Kjz1oNfYwS4TzGbjEWO

@oliviertassinari
Copy link
Member

oliviertassinari commented May 15, 2017

Thanks for letting us know. Let's close it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants