[LeftNav] Ripple not showing on menuItems

[CalebEverett]

Ripple effect doesn't trigger for menuItems specified as prop of LeftNav. Triggers if MenuItems are child components.

[oliviertassinari]

@CalebEverett Yeap, that's because the menuItems property is using the older version of the menu. I think that we should deprecate his usage. Though? @shaurya947

[shaurya947]

@oliviertassinari fine by me.. let's show a warning for now and keep it around.

@CalebEverett do you wanna take a shot at this and submit a PR?

[CalebEverett]

Happy to, can you point me in the right direction? Is this basically make it be based on the new menu-item instead of the old one?

[oliviertassinari]

@CalebEverett would help 🍺.
I see deferent things to do

• update the doc to use MenuItems as child component
• add a warning to those how are using the menuItems property. (you can have a look at Allow open state of dialog to be controlled through the show prop. #1996)

[CalebEverett]

I took a look at this and don't think I have the knowledge to get this done.

[alitaheri]

Being addressed in #2421

[alitaheri]

This is fixed by #2421