Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RefreshIndicator/CircularProgress] - Make CircularProgress be configurable to start out on full stroke #2582

Closed
Serfenia opened this issue Dec 18, 2015 · 5 comments
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module! new feature New feature or request out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@Serfenia
Copy link

Hey there,

As an enhancement I would like to see the CircularProgress to start on a large stroke instead of a small one, through a boolean configuration. What I mean with this is the following:

Small:
screen shot 2015-12-18 at 11 11 40

Large:
screen shot 2015-12-18 at 11 12 15

As an additional request I would like it to be configurable through the RefreshIndicator props as well. Maybe for a loading status add a startPercentage property?

Regards, Serfenia

@alitaheri
Copy link
Member

I don't quite follow what you wish to achieve.

As an enhancement I would like to see the CircularProgress to start on a large stroke instead of a small

What is the use case? I mean is it even noticeable?

you can use the value prop to set it to any percentage you like. can't you? O.o

@Serfenia
Copy link
Author

A refresh indicator that is only there for like 200 ms barely grows to a spinning one (So UI technical it is not even visible, only if you pay good attention). The animation of the line as you can see starts out small, and not large. The percentage unfortunately does not work, tried it.

@alitaheri
Copy link
Member

Interesting... I didn't think of it that way! Well we are very busy at the moment with the docs and code quality. Feel free to submit a PR 😁

@oliviertassinari oliviertassinari added the new feature New feature or request label Dec 31, 2015
@oliviertassinari oliviertassinari added component: CircularProgress The React component and removed component: CircularProgress The React component labels Dec 18, 2016
@mbrookes mbrookes added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Jan 17, 2017
@yched
Copy link

yched commented Feb 4, 2017

Not sure why it was 'won't fix'ed, this is very much a valid feature IMO.

Some server actions are unpredictably short or long, so the spinner can be visible for a couple seconds or just a couple frames.

In the latter case, the visual feedback is puzzling for end users : they just see an isolated dot (the spinner in "short stroke" state, that doesn't look like a spinner at all) appear and then disappear almost instantly.

It's not just cosmetics, it's about consistent reliability and clarity of the visual feedback provided by the CircularProgress component, regardless of how long it's visible. The issue with the current "indeterminate" mode is that you can only recognize the spinner as being a spinner if it stays displayed for more than 1/2 second or so. Shorter, it just looks like a glitch with no cognitive meaning.

This could simply be fixed if the spinner started out as an identifiable "section of a circle".

@mbrookes
Copy link
Member

mbrookes commented Feb 4, 2017

@yched Please refer to the spec for tips on how to use the refresh indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module! new feature New feature or request out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

5 participants