Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDeviceSize(Sizes.SMALL) will always return true in style-resizable.js #3660

Closed
halayli opened this issue Mar 10, 2016 · 2 comments
Closed
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@halayli
Copy link

halayli commented Mar 10, 2016

I am not sure if this is intended but isDeviceSize(Sizes.SMALL) will always be true regardless of the screen size since {3,2,1} >= 1.

@alitaheri
Copy link
Member

We intend to remove that mixin. It's proven a bit hard to do it, but we'll get there. So I think we shouldn't fix the mixin, just kill it 😮 🔫

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Mar 12, 2016
@tintin1343
Copy link
Contributor

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

4 participants