Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] has a block-like display in Microsoft Edge #4522

Closed
jbbae opened this issue Jun 18, 2016 · 6 comments
Closed

[AppBar] has a block-like display in Microsoft Edge #4522

jbbae opened this issue Jun 18, 2016 · 6 comments
Labels
bug 🐛 Something doesn't work component: app bar This is the name of the generic UI component, not the React module!

Comments

@jbbae
Copy link

jbbae commented Jun 18, 2016

Problem description

So the AppBar component doesn't appear as a single line in Mobile Microsoft Edge browsers. So for instance, if I had a simple AppBar with just a title, the title would appear below the left button instead of right next to it.

Steps to reproduce

Use a Microsoft edge browser in mobile to go to material-ui.com

Versions

  • Material-UI: v0.15.0
@jbbae
Copy link
Author

jbbae commented Aug 5, 2016

To provide more perspective, when I go on to the Material-UI website, the AppBar behaves weirdly, acting as block-like views instead of the single inline view that it's supposed to be. See image attached.

wp_ss_20160805_0002

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari changed the title AppBar has a block-like display in Microsoft Edge [AppBar] has a block-like display in Microsoft Edge Sep 17, 2016
@oliviertassinari oliviertassinari added the component: app bar This is the name of the generic UI component, not the React module! label Dec 18, 2016
@mfalaize
Copy link

I've the same problem with Epiphany browser (webkit rendered), it seems the issue come from the inline-style-prefixer dependency, even with the last version available (2.0.5). The display: flex is not rendered at all for those user-agents.

@mfalaize
Copy link

Actually, it seems the display: flex is not rendered when we use arrays in styles objects (i.e. display: ['flex', '-webkit-flex']) and for some unknown user-agents, inline-style-prefixer returns arrays with multiple values for the display attribute.

When we use arrays in styles objects, the corresponding css attribute is not rendered, regardless of the browser we use.

@mfalaize
Copy link

There are already some discussions about this issue #705, and React does not want to allow arrays in inline styles : facebook/react#723

@mfalaize
Copy link

It seems that returning arrays does not work with React V15 : robinweser/inline-style-prefixer#78 and necolas/react-native-web#131.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 16, 2017
@oliviertassinari
Copy link
Member

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: app bar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants