Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] TableRowColumn not handling long text well #5377

Closed
lucasbento opened this issue Oct 12, 2016 · 2 comments · Fixed by #5378
Closed

[Table] TableRowColumn not handling long text well #5377

lucasbento opened this issue Oct 12, 2016 · 2 comments · Fixed by #5378
Labels
component: table This is the name of the generic UI component, not the React module! v0.x

Comments

@lucasbento
Copy link

Problem description

0.15.4

image

0.16

image

Steps to reproduce

Provide a very long text to <TableRowColumn />: http://www.webpackbin.com/VkzfhMPRW

Seems to have been introduced by 252449d.

Versions

  • Material-UI: 0.16.0
  • React: 15.3.2
  • Browser: Chrome 53.0.2785.143 (64-bit)

If we remove the whiteSpace: nowrap, it will allow multiple lines, any idea on how we can fix this, @oliviertassinari ?

@lucasbento lucasbento added the bug 🐛 Something doesn't work label Oct 12, 2016
@oliviertassinari oliviertassinari added Regression and removed bug 🐛 Something doesn't work labels Oct 12, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 12, 2016

I'm fine with reverting 252449d. The <Tooltip /> should most likely be render outside of the current DOM hierarchy.

@BlockChange
Copy link

BlockChange commented Nov 15, 2016

I wish that multiline was an option, not the default, but to give a TableRow the multiLine option like a TextField, so that the whole row will be as high as the highest row, i.e. to add whiteSpace: 'normal' to each TableRowColumn, but also add an extra padding (about 12px?), because it doesn't look good without it.

Same for: TableHeader/TableHeaderColumn would be nice

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: table This is the name of the generic UI component, not the React module! v0.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants