Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdom > 11.1.0 breaks the build #7894

Closed
rosskevin opened this issue Aug 24, 2017 · 4 comments
Closed

jsdom > 11.1.0 breaks the build #7894

rosskevin opened this issue Aug 24, 2017 · 4 comments
Assignees
@oliviertassinari
Labels
external dependency Blocked by external dependency, we can’t do anything about it

Comments

@rosskevin
Copy link
Member

Problem description

a1a1799

This direct commit broke the build, though I see no obvious reason why. I am reverting that in #7890 so I can get it merged. We need to address jsdom separately.

/cc @oliviertassinari
@rosskevin rosskevin added external dependency Blocked by external dependency, we can’t do anything about it v1 labels Aug 24, 2017
@rosskevin
Copy link
Member Author

Ran yarn upgrade jsdom which went to ^11.2.0, and immediately yarn test:unit presents many errors.

@oliviertassinari
Copy link
Member

I confirm, I have been struggeling on this one to.

@oliviertassinari oliviertassinari self-assigned this Aug 24, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 24, 2017 •
edited
Loading

This looks like a regression given the tests are working in a real browser. jsdom/jsdom#1959

@oliviertassinari oliviertassinari changed the title jsdom > 11.1 breaks the build jsdom > 11.1.0 breaks the build Aug 24, 2017
@oliviertassinari
Copy link
Member

I'm closing the issue. I would rather not update jsdom and wait to see the issue fixed in the future than going down the rabbit hole 🐇 . Can be very deep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosskevin @oliviertassinari