Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] The Sync Plugin for the Community Figma file does not recognize changes to Switch component #369

Open
johnsuntb opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
bug 🐛 Something doesn't work figma scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@johnsuntb
Copy link

johnsuntb commented Jul 16, 2024

The problem in depth

I noticed in the MUI Sync Plugin documentation (https://mui.com/material-ui/design-resources/material-ui-sync/), it describes how to get the plugin to notice changes in the switch. However, when I attempted to recreate this, I ran into two main issues. The current Switch components in the MUI Figma file is not a component/component variant. It is a component instance which does not match the documentation showing that is a component with full range of customizability available. When I did simply try changing the color of the component instance of Primary Enabled Medium switch, the plugin did not generate theme code for that change.

Your environment

MUI for Figma Material UI v5.16.0

Search keywords: Sync Plugin Switch

@johnsuntb johnsuntb added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: question Community support but can be turned into an improvement labels Jul 16, 2024
@zannager zannager added figma scope: sync Issues related to the Material UI Sync Figma plugin labels Jul 17, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 31, 2024

The output of Material UI Sync looks all broken with MUI for Figma v5.17.0. We might simply remove the support for the components part of the theme export.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed support: question Community support but can be turned into an improvement labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work figma scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants