Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show for private repositories #12

Closed
JaKXz opened this issue Feb 16, 2016 · 3 comments · Fixed by #15
Closed

Don't show for private repositories #12

JaKXz opened this issue Feb 16, 2016 · 3 comments · Fixed by #15

Comments

@JaKXz
Copy link

JaKXz commented Feb 16, 2016

it would be great if the extension didn't make any calculations if the repo being looked at is private.

@musically-ut
Copy link
Owner

Interesting. I don't have a private repo handy to test this, but I will try to lay my hands on some.

In the meanwhile, does this extension break the user experience on Github in someway on private repos by throwing errors or messing up the display?

@JaKXz
Copy link
Author

JaKXz commented Feb 16, 2016

@musically-ut it doesn't break anything, but it does just display a "no information" string, which isn't really helpful.

@musically-ut
Copy link
Owner

Ah, the error message actually is that Github didn't provide any information about the repo. I think I just should keep the place blank instead of showing "no information" there.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants