Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovely Forks menu item #44

Open
Grossdm opened this issue Aug 8, 2018 · 2 comments
Open

Lovely Forks menu item #44

Grossdm opened this issue Aug 8, 2018 · 2 comments

Comments

@Grossdm
Copy link
Contributor

Grossdm commented Aug 8, 2018

On Fennec 60.0, there is a menu item for Lovely Forks regardless of the current website. I tapped it just to see if my phone would explode, but it did nothing.

Surely the menu item can be removed when not in GitHub?

Thanks,

Doug®

@musically-ut
Copy link
Owner

musically-ut commented Aug 9, 2018

Thanks for the report; I'm glad that your phone didn't explode. :)

I vaguely remember that page-action was not fully supported in Firefox and, hence, I had to make it into a Menu action. And then Chrome moved to showing the extension icons always and they had to be hidden manually one by one; so I forgot about this discrepancy completely.

I am not sure what the state of the affairs is now, but there is little point in the extension icon appearing on any menu at all. I will try to remove it completely in the next version and will ask you to check and close the issue.

Also, thanks for using Lovely Forks! 😊

@Grossdm
Copy link
Contributor Author

Grossdm commented Aug 10, 2018

Thank you for the response!

Fennec is getting a bit "unruly" with its menu and address bar icons. That is, with all the addons that I have installed. 😁

One example of excess is Dark Background and Light Text, also on GitHub. It places both an icon next to (on?) my address bar and an item in the menu.

The Fennec address bar on my Paleophone (Galaxy Note 3, my first non-Motorola and my last Samsung smartphone. LG? Sony?) is getting full with Fennec's ideas for a "Reader Mode" icon and most annoyingly a button/icon with the sole purpose of dropping a link to the URL on the home screen.

I think it would be nice if addons that need to add a menu item are provided a sub-menu.
This would be quicker to access than, well I have to scroll my menu if I have enough addons enabled.
I think it would be better than just dumping the addons' items onto the current menu.

Oh, and just in case Mozilla is reading, Please put a small 🔍 icon on the "Find in page" menu item!

Happy coding,

Doug®

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants