Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pjax problems : use MutationObserver instead #88

Open
payne911 opened this issue Jan 19, 2023 · 0 comments
Open

pjax problems : use MutationObserver instead #88

payne911 opened this issue Jan 19, 2023 · 0 comments
Assignees

Comments

@payne911
Copy link
Contributor

payne911 commented Jan 19, 2023

I just spent a few hours debugging my own Chrome Extension because the pjax events were not always being triggered.

Since I also had Lovely Forks enabled during my testing, I noticed you had the same problem as me, so I'm simply reaching out to you folks by pointing out to the commit's LOCs which resolved my issue: https://github.com/useful-forks/useful-forks.github.io/blob/65f19e50509a6a78bc7c71246247770312822c2f/plugin/useful-forks.js#L48-L68

Hopefully you'll find time to dig into this and integrate the MutationObserver in your extension as well 👍

If you want an easy test to reproduce what I'm talking about: go to your repository's main page, and click on any listed commit's title (see image).

image

You'll notice your extension's text will be gone.

@musically-ut musically-ut self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants