diff --git a/README_INTERNAL.md b/README_INTERNAL.md index 2770888c0..b8aceefda 100644 --- a/README_INTERNAL.md +++ b/README_INTERNAL.md @@ -13,6 +13,15 @@ Examples: - include `--scope '*-esm'` in the dev script - Run `npx lerna run dev --scope '*-esm'` locally after running `yarn dev` +## Testing your changes to see what affect they have on version updates + +You can do a dry-run locally of the `version:update` script by doing the following: + +1. Create a new branch from `main` +2. Cherry pick commits from your working branch to it, including any needed footer e.g. "BREAKING CHANGE: ..." +3. Push new branch to remote +4. Run the script `yarn version:update` and select 'n' (no) for committing to the changes + # Media Chrome Canaries It's helpful to point at Media Chrome canaries for developing PRs and having all the live examples work; however, we should not merge any PRs that point at a Media Chrome Canary release. diff --git a/packages/mux-player-react/src/index.tsx b/packages/mux-player-react/src/index.tsx index d61d4449b..2647ee910 100644 --- a/packages/mux-player-react/src/index.tsx +++ b/packages/mux-player-react/src/index.tsx @@ -1,5 +1,4 @@ 'use client'; - import React, { useEffect } from 'react'; import type { CSSProperties } from 'react'; import type { diff --git a/packages/mux-player/src/html.ts b/packages/mux-player/src/html.ts index 98eab6c84..f6f648f44 100644 --- a/packages/mux-player/src/html.ts +++ b/packages/mux-player/src/html.ts @@ -1,5 +1,4 @@ import { document } from './polyfills'; -// @ts-ignore import { TemplateInstance, ChildNodePart, AttrPart, Part } from 'media-chrome/dist/media-theme-element.js'; // NOTE: These are either direct ports or significantly based off of github's jtml template part processing logic. For more, see: https://github.com/github/jtml