From cb518c70ee037722f802d808bbbe93da83f07fb3 Mon Sep 17 00:00:00 2001 From: Toru Nagashima Date: Sun, 14 Jul 2019 17:50:15 +0900 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix=20hasSideEffect=20false=20ne?= =?UTF-8?q?gative?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docs/api/ast-utils.md | 1 + src/has-side-effect.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/docs/api/ast-utils.md b/docs/api/ast-utils.md index d433a64..4004355 100644 --- a/docs/api/ast-utils.md +++ b/docs/api/ast-utils.md @@ -363,6 +363,7 @@ The side effect means that it *may* modify a certain variable or object member. - `AssignmentExpression` - `AwaitExpression` - `CallExpression` +- `ImportExpression` - `NewExpression` - `UnaryExpression` (`[operator = "delete"]`) - `UpdateExpression` diff --git a/src/has-side-effect.js b/src/has-side-effect.js index fe0a038..5ae28ee 100644 --- a/src/has-side-effect.js +++ b/src/has-side-effect.js @@ -83,6 +83,9 @@ const visitor = Object.freeze( FunctionExpression() { return false }, + ImportExpression() { + return true + }, MemberExpression(node, options, visitorKeys) { if (options.considerGetters) { return true