Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace-overview-confirm behaves unexpectedly with custom keybindings #265

Open
cryhot opened this issue Oct 13, 2023 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@cryhot
Copy link

cryhot commented Oct 13, 2023

I wanted to redefine my keybindings to close the overview popup to Super+W, because why would I have two different shortcuts for opening and closing where I could have one, and keep my fingers on the same keys?

As specified in the wiki, I redefined workspace-overview-confirm, and found several bugs.
In the following I assume that I have workspace-overview-toggle to the default value ("['<Super>w']"), but behavior is the same if switching ws and us in every keybinding.

  • workspace-overview-confirm="['<Super>w']" (same as workspace-overview-toggle) 🔴
    Simply does not work. The popup will not close when pressing Super+W.
  • workspace-overview-confirm="['<Super>u']" (different keybind) 🟡
    Weirdly, Super+U has no effect, but Super+U+U does the job.
  • workspace-overview-confirm="['u', '<Shift><Super>u', '<Shift><Super>w']" (any of these) 🟢
    Works as expected, no repetition required.

By the way, workspace-overview-toggle doesn't toggle the popup, it only opens it. I don't know if it is a bug or a feature, but definitively misleading.

@mzur
Copy link
Owner

mzur commented Nov 4, 2023

Thanks for the report! I'm not sure if anything can be done about this, as it might be the default behavior with all keybindings (e.g. if you set the same keys for different actions). But someone could definitely have a look if this can be improved.

@mzur mzur added the help wanted Extra attention is needed label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants