Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude_lines block exclude does not work correctly with new line def #1472

Closed
MalteBecker opened this issue Oct 17, 2022 · 1 comment
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists exclude

Comments

@MalteBecker
Copy link

Describe the bug
I want to exclude complete functions with the exclude_lines config parameter. The documentation says this works if i just add "def xyz". This only works if the def definition ends in the same line.

To Reproduce
Have "def asyncio" in your [report] exclude_lines

This will work:

async def asyncio(*,client: Client,) -> Optional[Union[Any, List[GltfFile]]]:
    return (
        await asyncio_detailed(
            client=client,
        )
    ).parsed

This will not work:

async def asyncio(
    *,
    client: Client,
) -> Optional[Union[Any, List[GltfFile]]]:
    return (
        await asyncio_detailed(
            client=client,
        )
    ).parsed

Expected behavior
Both versions will exclude the complete function.

@MalteBecker MalteBecker added bug Something isn't working needs triage labels Oct 17, 2022
@nedbat nedbat added duplicate This issue or pull request already exists exclude and removed needs triage labels Oct 18, 2022
@nedbat
Copy link
Owner

nedbat commented Oct 18, 2022

This is a duplicate of #684.

@nedbat nedbat closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists exclude
Projects
None yet
Development

No branches or pull requests

2 participants