Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSS Site to Gatsby v3.8 #803

Closed
4 tasks done
jpvajda opened this issue Jun 23, 2021 · 5 comments · Fixed by #805 or #806
Closed
4 tasks done

Update OSS Site to Gatsby v3.8 #803

jpvajda opened this issue Jun 23, 2021 · 5 comments · Fixed by #805 or #806
Assignees
Labels

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Jun 23, 2021

Due to the Gatsby Cloud bug being resolved in this Gatsby issue(gatsbyjs/gatsby#32042) we'll need to bump our version of Gatsby to v3.8

Acceptance Criteria

  • Upgrade site to Gatsby v3.8
  • Test site visually
  • Test if a PR builds
  • fix issue with 🥕 s

Bug

PRs fail to build on Gatsby Cloud sites that don't have gatsby 3.8 or is using gatsby-plugin-gatsby-cloud@2.8.1

Screen Shot 2021-06-22 at 4 00 31 PM

@jpvajda jpvajda added gatsbysites enhancement New feature or request labels Jun 23, 2021
@moonlight-komorebi moonlight-komorebi self-assigned this Jun 29, 2021
@rudouglas rudouglas linked a pull request Jun 29, 2021 that will close this issue
@rudouglas
Copy link
Contributor

This seems to be building correctly, however, I noticed an issue with Carets in the filter section:
https://opensourcewebsitedevelop-ruairiupdategatsby38.gtsb.io/explore-projects
Screenshot 2021-06-29 at 18 32 13

Will need to dig into this further

@moonlight-komorebi
Copy link
Contributor

i dont think i have enough knowledge to effectively speak to the problem @rudouglas mentioned, but ill write down my thoughts & research 🙈

one weird thing i noticed when investigating this is that when you do a local / develop build, the site is fine & the icon is regularly sized. this issue is only encountered when doing a production build.

the image lives in the repo and has a specified height and width, but when loaded, we get an image that is missing those attributes:
in the repo:

<svg width="8" height="5" viewBox="0 0 8 5" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M6.59998 0.5L3.99998 3.2L1.39998 0.5L0.599976 1.3L3.99998 4.6L7.39998 1.3L6.59998 0.5Z" fill="#8E9494"/>
</svg>

on page load:

<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 8 5"><path fill="#8E9494" fill-rule="evenodd" d="M6.6.5 4 3.2 1.4.5l-.8.8L4 4.6l3.4-3.3-.8-.8z" clip-rule="evenodd"/></svg>

at the moment, im not sure where to look at account for this difference or how to address it.

@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 30, 2021

We decided to pause on this upgrade and investigate if by upgrading the dev site, to 3.8 we'd see similar issues in CSS. it seems we don't use the project search component anywhere else on our sites, so this may just be an OSS problem to resolve to be able to bump that site to Gatsby 3.8

Once we prioritize this, we can determine root cause and approach to fix this.

@jpvajda
Copy link
Contributor Author

jpvajda commented Jun 30, 2021

References to some troubleshooting Kris did

This was the issue: gatsbyjs/gatsby#17914
Which I got to from here I believe: gatsbyjs/gatsby#8560

@jpvajda
Copy link
Contributor Author

jpvajda commented Jul 2, 2021

@LizBaker is swapping these custom 🥕s to our standard 🥕 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants