Error on "Join call" is not shown to user

[nickvergessen]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

• Extracting from Recording consent not offered by the frontend if local server doesn't have it #13045

Steps to reproduce

1. As a user try to join a call
2. Receive a 400 response, see patch below for hardcoded 400

diff --git a/lib/Controller/CallController.php b/lib/Controller/CallController.php
index 373337913..c8a6fe00f 100644
--- a/lib/Controller/CallController.php
+++ b/lib/Controller/CallController.php
@@ -136,6 +136,7 @@ class CallController extends AEnvironmentAwareController {
        #[RequireParticipant]
        #[RequireReadWriteConversation]
        public function joinCall(?int $flags = null, ?int $forcePermissions = null, bool $silent = false, bool $recordingConsent = false): DataResponse {
+               return new DataResponse(['error' => 'consent'], Http::STATUS_BAD_REQUEST);
                try {
                        $this->validateRecordingConsent($recordingConsent);
                } catch (\InvalidArgumentException) {

Expected behaviour

You see an/the error message

Actual behaviour

Browser warning about leaving the page:

[Souptik2001]

Hey @nickvergessen I am not sure about the exact design that was required (like whether the error message should be just a toast using showError() or not), but does this look good? -

Screen.Recording.2024-08-24.at.6.15.30.PM.mov

If yes then I have raised a PR for this above.