Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Chip has accessibility issue when it has close button #2802

Closed
withden opened this issue Apr 19, 2024 · 1 comment · Fixed by #3300
Closed

[BUG] - Chip has accessibility issue when it has close button #2802

withden opened this issue Apr 19, 2024 · 1 comment · Fixed by #3300
Assignees
Labels
♿ Scope : Accessibility Related to accessibility 🐛 Type: Bug Something isn't working

Comments

@withden
Copy link
Contributor

withden commented Apr 19, 2024

NextUI Version

2.3.5

Describe the bug

Hi,

Chip has low accessibility when it has a close button. Because that button hasn't any aria label, I tried to find it in docs as well in code, but I can't find anything that can help me to give some props to the close button.

If this is already present then give me that docs link otherwise give me some hint (code flow) so can create a PR request for that

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

  1. Go to https://nextui.org/docs/components/chip
  2. Open Chrome console and do Lighthouse perf report

Expected behavior

Somehow I can pass props to that button element so that I can make it more SEO-friendly

Screenshots or Videos

image

Operating System Version

Ubuntu 23.04 (Linux - Kernal 6.5.0-26-generic)

Browser

Chrome

Copy link

linear bot commented Apr 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿ Scope : Accessibility Related to accessibility 🐛 Type: Bug Something isn't working
Projects
None yet
3 participants