Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display App Store releaseNotes when showOnFirstLaunch is set to true #49

Open
karlbecker opened this issue Sep 26, 2013 · 2 comments
Open

Comments

@karlbecker
Copy link

The library is generally working great, but I seem to be hitting a problem: when the user launches the latest version for the first time, it will show the releaseNotes only when specified via localVersionsPlistPath, and not from the App Store's API response.

I have set

[iVersion sharedInstance].showOnFirstLaunch = YES;

in the AppDelegate's

    + (void)initialize;

When the version is the same, it shows no alert on first launch.

However, when I add this line (and the associated versions.plist to my bundle):

[iVersion sharedInstance].localVersionsPlistPath = @"versions.plist";

then it shows the message specified locally, as I would expect.

I do not want to have to remember to update my app bundle each submission just to show this reminder when a user upgrades.

Is this a bug in the library? Or am I neglecting to do something?

Thanks!

  • Karl
@nicklockwood
Copy link
Owner

iVersion doesn't currently have the feature of showing the latest installed version's release notes automatically from the app store. This is a good idea, and something I've been thinking about adding, especially now that auto-updating on iOS 7 has made the other functionality less important.

@karlbecker
Copy link
Author

Definitely. Looking at the code really quickly, I didn't see an obvious place to insert the necessary call. If you can point me to about where, then I can quickly implement it - of course, you'll probably do it quicker and more accurately than me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants