Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localVersionsPlistPath property name is confusing #79

Open
stevenp opened this issue May 20, 2015 · 1 comment
Open

localVersionsPlistPath property name is confusing #79

stevenp opened this issue May 20, 2015 · 1 comment

Comments

@stevenp
Copy link

stevenp commented May 20, 2015

I couldn't get the local release notes to display, and I realized that it was because this property actually expects a file name, not a path. I think this property should either be renamed localVersionsPlistFileName, or the logic should be updated to detect if it's been set to a full path, and not to append it to [[NSBundle mainBundle] resourcePath] in that circumstance.

@sfoulston-laughable
Copy link

+1. Totally agree with this, just got caught out by the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants