Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation Time Range / Recurring Time #3112

Open
belevine opened this issue Dec 14, 2023 · 4 comments
Open

Automation Time Range / Recurring Time #3112

belevine opened this issue Dec 14, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@belevine
Copy link

belevine commented Dec 14, 2023

AAPS 3.2.0.2

In automations, it is not possible to create a time range for recurring times. This would be useful to select only specific days of the week to have an action taken during a time range. Currently, recurring time automations can only be set to occur at a specific time, and time ranges occur on all days.

This request is to have the day of week selection added to the time range trigger or to add time range to the recurring time trigger.

@belevine belevine changed the title Automation Recurring Time Automation Time Range Dec 14, 2023
@belevine belevine changed the title Automation Time Range Automation Time Range / Recurring Time Dec 14, 2023
@MilosKozak MilosKozak added the enhancement New feature or request label Dec 20, 2023
@TimVroom
Copy link

TimVroom commented Jan 26, 2024

At the moment I have a locally edited version that includes this:
Just a simplified version of the recurring time trigger which you can only select the date.
This works great in combination with a time range or any of the other triggers for me.

So my question is:

why the need to include the other already existing triggers into one for recurring purposes? Isn't a single day selector more then enough?

I could make a PR for this if there is any interest, but im not sure about all the inner workings, so not sure it would be accepted. (will link this issue just in case)

@belevine
Copy link
Author

At the moment I have a locally edited version that includes this: Just a simplified version of the recurring time trigger which you can only select the date. This works great in combination with a time range or any of the other triggers for me.

So my question is:

why the need to include the other already existing triggers into one for recurring purposes? Isn't a single day selector more then enough?

I could make a PR for this if there is any interest, but im not sure about all the inner workings, so not sure it would be accepted. (will link this issue just in case)

Yes, a day selector in combination with a time range is what I am looking to do. I can't figure out how to do that with the current triggers; is it possible?

@TimVroom
Copy link

TimVroom commented Jan 29, 2024

@belevine Seems like the PR is accepted: so in the upcomming version it should be working.
So with the current 3.2.x version it is not possible (as far as i know)

@belevine
Copy link
Author

@belevine Seems like the PR is accepted: so in the upcomming version it should be working. So with the current 3.2.x version it is not possible (as far as i know)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants