Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS & Canvas Garbage Collection #199

Closed
sandstrom opened this issue Aug 20, 2020 · 3 comments
Closed

iOS & Canvas Garbage Collection #199

sandstrom opened this issue Aug 20, 2020 · 3 comments

Comments

@sandstrom
Copy link
Contributor

I noticed this iOS issue, which mentions that canvas garbage collection doesn't work unless canvas width/height it set to 0 after use.

https://bugs.webkit.org/show_bug.cgi?id=195325

I'm not saying this is something that should be implemented, but I'm curious if you've heard about crash issues when using Pica on iOS? If so, I just wanted to mention that this may be the reason.

@sandstrom sandstrom changed the title iOS and Garbage Collection iOS & Canvas Garbage Collection Aug 20, 2020
@puzrin
Copy link
Member

puzrin commented Aug 20, 2020

SO ref: https://stackoverflow.com/questions/52532614/total-canvas-memory-use-exceeds-the-maximum-limit-safari-12

I don't remember such issues. That's strange.

@sandstrom
Copy link
Contributor Author

sandstrom commented Aug 20, 2020

Not something that needs to be tackled, necessarily. I can see the downside of trying to patch a hole we don't know exist, or can't easily verify exist.

But just wanted to put this out here, since it may be relevant.

@puzrin puzrin closed this as completed in b51a832 Aug 20, 2020
@sandstrom
Copy link
Contributor Author

@puzrin Wow, that was quick 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants