Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLACK_WEBHOOK secret to nodejs/node-v8 #553

Closed
mmarchini opened this issue Sep 14, 2020 · 7 comments
Closed

Add SLACK_WEBHOOK secret to nodejs/node-v8 #553

mmarchini opened this issue Sep 14, 2020 · 7 comments
Labels
approved Request approved by TSC/CommComm

Comments

@mmarchini
Copy link
Contributor

Slack webhook in the OpenJS Foundation slack (channel #nodejs-v8-canary) for important notifications on the nodejs/node-v8 repository.

Ref: nodejs/node-v8#171 (comment)

@mmarchini
Copy link
Contributor Author

cc @nodejs/tsc @nodejs/community-committee

@mhdawson
Copy link
Member

I should probably know the answer but @mmarchini does this mean that additional people who have access to nodejs/node-v8 will now have access to the secret?

@mmarchini
Copy link
Contributor Author

No, the secret is only visible while I'm setting, after that GitHub will mask it on logs (and when editing users can only enter new values, the old value won't show up).

@mmarchini
Copy link
Contributor Author

Cc @nodejs/community-committee need one more +1

@Trott
Copy link
Member

Trott commented Sep 24, 2020

+1 (but I'm not on CommComm....)

@bnb
Copy link
Contributor

bnb commented Oct 6, 2020

+1

@mmarchini mmarchini added the approved Request approved by TSC/CommComm label Oct 6, 2020
@mmarchini
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Request approved by TSC/CommComm
Projects
None yet
Development

No branches or pull requests

4 participants