Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer flakey5/node-with-r2-poc to nodejs/dist-worker #820

Closed
flakey5 opened this issue Aug 18, 2023 · 12 comments
Closed

Transfer flakey5/node-with-r2-poc to nodejs/dist-worker #820

flakey5 opened this issue Aug 18, 2023 · 12 comments

Comments

@flakey5
Copy link
Member

flakey5 commented Aug 18, 2023

Re nodejs/build#3461

Could this repo https://github.com/flakey5/node-with-r2-poc get transferred over to the Node org? It is the poc for serving the /home/dist folder over R2.

Additionally, could I be invited to the Node org?

cc @ovflowd @jasnell

@MoLow
Copy link
Member

MoLow commented Aug 19, 2023

+1. adding the to build adgenda

@mhdawson
Copy link
Member

+1 to moving repo over. I think it might need a CONTRIBUTING.md and not sure about CODE_OF_CONDUCT.md as it might be inherited from some higher level config.

@flakey5
Copy link
Member Author

flakey5 commented Aug 23, 2023

I think it might need a CONTRIBUTING.md and not sure about CODE_OF_CONDUCT.md

I think both of those are inherited from https://github.com/nodejs/.github?

@mhdawson
Copy link
Member

@flakey5 thanks for confirming

@ovflowd
Copy link
Member

ovflowd commented Aug 31, 2023

@MoLow was this discussed on the last Build Meeting? Shouldn't this be TSC Agenda?

@tniessen
Copy link
Member

tniessen commented Sep 1, 2023

Two thoughts:

  • The concept (and perhaps implementation) should probably be reviewed by the Build WG if it hasn't already. (It looks like none of the champions mentioned in Cloudflare R2 Workers build#3461 are Build WG members.)
  • The proposed repository name is way too generic in my opinion. It should accurately describe what the exact purpose of the repository is.

@MoLow
Copy link
Member

MoLow commented Sep 1, 2023

was this discussed on the last Build Meeting? Shouldn't this be TSC Agenda?

There wasn't a meeting yet, and I do not see a reason to get the TSC involved just yet - everything is pretty agreed and straightforward

The concept (and perhaps implementation) should probably be reviewed by the Build WG if it hasn't already. (It looks like none of the champions mentioned in nodejs/build#3461 are Build WG members.)

I reviewed this, and I am happy to be added as a champion as well

@flakey5
Copy link
Member Author

flakey5 commented Sep 1, 2023

proposed repository name is way too generic in my opinion.

How about nodejs/dist-worker?

@flakey5 flakey5 changed the title Transfer flakey5/node-with-r2-poc to nodejs/cloudflare-workers Transfer flakey5/node-with-r2-poc to nodejs/dist-worker Sep 7, 2023
@Trott
Copy link
Member

Trott commented Sep 13, 2023

Additionally, could I be invited to the Node org?

Since @ovflowd wants to add @flakey5 to the @nodejs/web-infra team, that will take care of the org invitation. (I'll add them right now.)

@flakey5
Copy link
Member Author

flakey5 commented Sep 13, 2023

Thanks!

@MoLow
Copy link
Member

MoLow commented Sep 26, 2023

Discussed this in the last Build WG meeting. going to take care of this

@MoLow
Copy link
Member

MoLow commented Sep 26, 2023

transferred to https://github.com/nodejs/release-cloudflare-worker
will continue working on it at nodejs/build#3461

@MoLow MoLow closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants