Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use node-stress-single-test with Windows due to three minute timeout #1281

Closed
Trott opened this issue May 23, 2018 · 3 comments
Closed

Comments

@Trott
Copy link
Member

Trott commented May 23, 2018

I tried to run Windows stress tests for nodejs/node#20836 (comment) to see how often it fails but after compiling for a long time, the builds hit a three-minute timeout and don't run the tests. See https://ci.nodejs.org/job/node-stress-single-test/1858/nodes=win2016-1p-vs2017/console and https://ci.nodejs.org/job/node-stress-single-test/1857/nodes=win2016-1p-vs2017/console.

19:31:05      Creating library c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\Release\mksnapshot.lib and object c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\Release\mksnapshot.exp
19:31:05   Generating code
19:34:05 Build timed out (after 3 minutes). Marking the build as aborted.
19:34:05 Build was aborted
19:34:05 Notifying upstream projects of job completion
19:34:05 Finished: ABORTED

@nodejs/build

@joaocgreis
Copy link
Member

This was added by @refack in https://ci.nodejs.org/job/node-stress-single-test/jobConfigHistory/showDiffFiles?timestamp1=2018-03-27_05-14-08&timestamp2=2018-04-07_18-17-38 (but might have been unintentional? Jenkins sometimes changes the jobs on the first save after plugins are updated).

Linking can take a very long time without output in our single processor machines. I've changed the time out from 3 minutes to 1 hour, we might need to decrease if this turns out to be too much.

Rebuilding jobs:

@refack
Copy link
Contributor

refack commented May 23, 2018

+1 to one hour (WRT to linking taking a looooooong time)

@Trott
Copy link
Member Author

Trott commented May 23, 2018

That fixed it. Thanks!

@Trott Trott closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants