Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --keychain-profile to notarytool #3545

Closed
5 tasks done
UlisesGascon opened this issue Oct 26, 2023 · 1 comment
Closed
5 tasks done

Add --keychain-profile to notarytool #3545

UlisesGascon opened this issue Oct 26, 2023 · 1 comment
Labels
enhancement platform:osx

Comments

@UlisesGascon
Copy link
Member

UlisesGascon commented Oct 26, 2023 •
edited
Loading

Refactor the script tools/osx-notarize.sh to use --keychain-profile and update the manual steps to store the credentials

Current status
@UlisesGascon UlisesGascon mentioned this issue Oct 26, 2023
Closed
This was referenced Nov 13, 2023
Merged
Closed
@UlisesGascon
Copy link
Member Author

The changes were shipped in 21.3.0, 20.11.0 and 18.19.1. So I will close the issue as nothing is pending 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement platform:osx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: use OSX Keychain profile to notarize the releases UlisesGascon/node
1 participant
@UlisesGascon