Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to Publish to Github Docker Registry #1392

Closed
yordis opened this issue Nov 10, 2020 · 7 comments
Closed

Add GitHub Action to Publish to Github Docker Registry #1392

yordis opened this issue Nov 10, 2020 · 7 comments

Comments

@yordis
Copy link

yordis commented Nov 10, 2020

Hey there,

Since Docker is rate-limiting pulling the images from Docker Hub, would be amazing if we could leverage GitHub Docker Registry to publish the official image as an alternative for the community.

@PeterDaveHello
Copy link
Member

Sounds good, pull requests are welcome!

@yordis
Copy link
Author

yordis commented Nov 11, 2020

@PeterDaveHello will work on it then, thanks a lot!

@yordis
Copy link
Author

yordis commented Dec 12, 2020

@PeterDaveHello sorry for the late response, I completely forgot about this, I created a PR for this issue.

@nschonni
Copy link
Member

It appears that it's only free during the Beta https://docs.github.com/en/free-pro-team@latest/packages/guides/migrating-to-github-container-registry-for-docker-images#billing-changes and then Node would be expected to pay for it, so I don't think this is a good idea

@nschonni
Copy link
Member

Maybe it is staying free for public though? The other issue I see is we can't build the architectures that the official images do.
This is something we'd need to bring to the admin/TSC before being implementing, but I'll leave that to one of the other maintainers if they're interested.

@yordis
Copy link
Author

yordis commented Dec 12, 2020

Maybe it is staying free for public though? The other issue I see is we can't build the architectures that the official images do.

@nschonni honestly, I thought it was free for public images, but no clue about the details now that you bring it up.

This is something we'd need to bring to the admin/TSC before being implementing, but I'll leave that to one of the other maintainers if they're interested.

Word! I created the PR and I was curious to know how to get it to work, I leave the rest to you.

@nschonni
Copy link
Member

nschonni commented Jul 7, 2021

Closing as per #1410 (comment)

@nschonni nschonni closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants