Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Loaders Team Meeting 2023-03-28 #134

Closed
mhdawson opened this issue Mar 24, 2023 · 7 comments
Closed

Node.js Loaders Team Meeting 2023-03-28 #134

mhdawson opened this issue Mar 24, 2023 · 7 comments
Assignees

Comments

@mhdawson
Copy link
Member

Time

UTC Tue 28-Mar-2023 18:00 (06:00 PM):

Timezone Date/Time
US / Pacific Tue 28-Mar-2023 11:00 (11:00 AM)
US / Mountain Tue 28-Mar-2023 12:00 (12:00 PM)
US / Central Tue 28-Mar-2023 13:00 (01:00 PM)
US / Eastern Tue 28-Mar-2023 14:00 (02:00 PM)
EU / Western Tue 28-Mar-2023 19:00 (07:00 PM)
EU / Central Tue 28-Mar-2023 20:00 (08:00 PM)
EU / Eastern Tue 28-Mar-2023 21:00 (09:00 PM)
Moscow Tue 28-Mar-2023 21:00 (09:00 PM)
Chennai Tue 28-Mar-2023 23:30 (11:30 PM)
Hangzhou Wed 29-Mar-2023 02:00 (02:00 AM)
Tokyo Wed 29-Mar-2023 03:00 (03:00 AM)
Sydney Wed 29-Mar-2023 05:00 (05:00 AM)

Or in your local time:

Links

Agenda

Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • console.log failure while working with worker threads. #30491

Invited

  • Loaders team: @nodejs/loaders

Observers/Guests

Notes

The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Mar 24, 2023
@GeoffreyBooth
Copy link
Member

Is there a reason to meet today? I’m not sure why nodejs/node#30491 is on the agenda.

@aduh95
Copy link
Contributor

aduh95 commented Mar 28, 2023

I’m not sure why nodejs/node#30491 is on the agenda.

Because console.log flakiness inside worker threads is an issue for loaders (and has been a pain for our own tests). If we have time, we could discuss what solutions we could come up with.

@GeoffreyBooth
Copy link
Member

I’m not sure I can attend today, but if you’d like to meet please feel free. @aduh95 or @JakobJingleheimer I assume either of you can run the Zoom/YouTube?

@JakobJingleheimer
Copy link
Contributor

I can meet. Do we need to make a decision (that should be recorded) or just pair/brainstorm (which could just be a huddle)?

@GeoffreyBooth
Copy link
Member

I’m not sure what decision could need to be made? If you find a solution for the console.log issues then I think just make a PR, and if there are any tradeoffs involved they can be analyzed in the context of landing that PR.

@JakobJingleheimer
Copy link
Contributor

Sounds like we don't need an official meeting then?

Michaël has a clever idea which he pushed earlier today that hopefully will do the trick (theoretically, I can't see why it wouldn't work). So 🤞

@aduh95
Copy link
Contributor

aduh95 commented Mar 28, 2023

I’m not sure what decision could need to be made? If you find a solution for the console.log issues then I think just make a PR, and if there are any tradeoffs involved they can be analyzed in the context of landing that PR.

That's what I made in nodejs/node#47036, but given the lack of interactions on that PR, it was hoping discussing it in the loaders meeting would be more productive. I'm fine skipping, it sounds like Michaël may have find another solution, so it's not as urgent to find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants