Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.4.0 should've been semver-major #2873

Closed
blattersturm opened this issue Jun 15, 2023 · 3 comments
Closed

9.4.0 should've been semver-major #2873

blattersturm opened this issue Jun 15, 2023 · 3 comments
Labels

Comments

@blattersturm
Copy link

blattersturm commented Jun 15, 2023

We're stuck running on Node.js 12.x due to node-ffi-napi being nondeterministically broken on any release above 14.x.

In this project, we install node-gyp@9, but since 9.4.0 bumped to make-fetch-happen@11 (via 02480f6) which has a semver-major change that propagates downward, installing fails as such:

error make-fetch-happen@11.1.1: The engine "node" is incompatible with this module. Expected version "^14.17.0 || ^16.13.0 || >=18.0.0". Got "12.22.12"
error Found incompatible module.

From the make-fetch-happen changelog:

⚠️ BREAKING CHANGES

  • make-fetch-happen is now compatible with the following semver range for node: ^14.17.0 || ^16.13.0 || >=18.0.0

Another failing in this amazing 'semver' system? Probably.

@cclauss
Copy link
Contributor

cclauss commented Jun 15, 2023

Have you reviewed and approved #2849 ?

@blattersturm
Copy link
Author

blattersturm commented Jun 15, 2023

Ah, I didn't see that one. Whoops, that's on me for not checking beforehand - ouch though at how a release shipped without solving this. :(

@lukekarrys
Copy link
Member

lukekarrys commented Oct 27, 2023

v9.4.1 has been released which reverts the dependency changes (#2917) that caused this issue. Those changes will be released again as v10.0.0 with the changelog outlining the newly supported Node versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants