From 09f35a49e376cc6c8b5a74faa5b04517aa6fd3be Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Fri, 4 Nov 2016 14:04:00 -0700
Subject: [PATCH] test: provide duration/interval to timers

There are places in the code base where setTimeout() or
setInterval() are called with just a callback and no duration/interval.
The timers module will use a value of `1` in that situation.

An unspecified duration or interval can be confusing. Did the original
author forget to provide a value? Did they intend to use setImmediate()
or process.nextTick() instead of setTimeout()? And so on.

This change provides a duration or interval of `1` to all calls in the
codebase where it is missing. `parallel/test-timers.js` still tests the
situation where `setTimeout()` and `setInterval()` are called with
`undefined` and other non-numeric values for the duration/interval.

PR-URL: https://github.com/nodejs/node/pull/9472
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/message/timeout_throw.js                        | 2 +-
 test/parallel/test-handle-wrap-close-abort.js        | 2 +-
 test/parallel/test-stream-end-paused.js              | 2 +-
 test/parallel/test-stream-readable-event.js          | 6 +++---
 test/parallel/test-stream2-large-read-stall.js       | 2 +-
 test/parallel/test-stream2-readable-non-empty-end.js | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/message/timeout_throw.js b/test/message/timeout_throw.js
index 14291fabd12565..4008f306fe58be 100644
--- a/test/message/timeout_throw.js
+++ b/test/message/timeout_throw.js
@@ -4,4 +4,4 @@ require('../common');
 setTimeout(function() {
   // eslint-disable-next-line no-undef
   undefined_reference_error_maker;
-});
+}, 1);
diff --git a/test/parallel/test-handle-wrap-close-abort.js b/test/parallel/test-handle-wrap-close-abort.js
index 5355e65df60821..e9f69195ad29cd 100644
--- a/test/parallel/test-handle-wrap-close-abort.js
+++ b/test/parallel/test-handle-wrap-close-abort.js
@@ -13,4 +13,4 @@ setTimeout(function() {
   setTimeout(function() {
     throw new Error('setTimeout');
   }, 1);
-});
+}, 1);
diff --git a/test/parallel/test-stream-end-paused.js b/test/parallel/test-stream-end-paused.js
index 3c46d49ea65d65..4b585fdb999890 100644
--- a/test/parallel/test-stream-end-paused.js
+++ b/test/parallel/test-stream-end-paused.js
@@ -21,7 +21,7 @@ stream.pause();
 setTimeout(common.mustCall(function() {
   stream.on('end', common.mustCall(function() {}));
   stream.resume();
-}));
+}), 1);
 
 process.on('exit', function() {
   assert(calledRead);
diff --git a/test/parallel/test-stream-readable-event.js b/test/parallel/test-stream-readable-event.js
index a20fc2ee732d0f..a8536bdcbab861 100644
--- a/test/parallel/test-stream-readable-event.js
+++ b/test/parallel/test-stream-readable-event.js
@@ -20,7 +20,7 @@ const Readable = require('stream').Readable;
     // we're testing what we think we are
     assert(!r._readableState.reading);
     r.on('readable', common.mustCall(function() {}));
-  });
+  }, 1);
 }
 
 {
@@ -40,7 +40,7 @@ const Readable = require('stream').Readable;
     // assert we're testing what we think we are
     assert(r._readableState.reading);
     r.on('readable', common.mustCall(function() {}));
-  });
+  }, 1);
 }
 
 {
@@ -60,5 +60,5 @@ const Readable = require('stream').Readable;
     // assert we're testing what we think we are
     assert(!r._readableState.reading);
     r.on('readable', common.mustCall(function() {}));
-  });
+  }, 1);
 }
diff --git a/test/parallel/test-stream2-large-read-stall.js b/test/parallel/test-stream2-large-read-stall.js
index 823407d396afb6..a2ae3f5174272d 100644
--- a/test/parallel/test-stream2-large-read-stall.js
+++ b/test/parallel/test-stream2-large-read-stall.js
@@ -46,7 +46,7 @@ function push() {
 
   console.error('   push #%d', pushes);
   if (r.push(Buffer.allocUnsafe(PUSHSIZE)))
-    setTimeout(push);
+    setTimeout(push, 1);
 }
 
 process.on('exit', function() {
diff --git a/test/parallel/test-stream2-readable-non-empty-end.js b/test/parallel/test-stream2-readable-non-empty-end.js
index c08cc287ce1cbf..dd2cb8d51055c7 100644
--- a/test/parallel/test-stream2-readable-non-empty-end.js
+++ b/test/parallel/test-stream2-readable-non-empty-end.js
@@ -16,7 +16,7 @@ test._read = function(size) {
   var chunk = chunks[n++];
   setTimeout(function() {
     test.push(chunk === undefined ? null : chunk);
-  });
+  }, 1);
 };
 
 test.on('end', thrower);
@@ -31,7 +31,7 @@ test.on('readable', function() {
   if (res) {
     bytesread += res.length;
     console.error('br=%d len=%d', bytesread, len);
-    setTimeout(next);
+    setTimeout(next, 1);
   }
   test.read(0);
 });