Skip to content

Commit

Permalink
test: make debugging of inspector-port-zero easier
Browse files Browse the repository at this point in the history
If the process was killed, then the exit code will be null, in which
case knowing the signal is really helpful.

PR-URL: #16685
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
gibfahn authored and MylesBorins committed Dec 11, 2017
1 parent 9914bca commit 15b6bcf
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/sequential/test-inspector-port-zero.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ function test(arg, port = '') {
};
proc.stdout.on('close', mustCall(() => onclose()));
proc.stderr.on('close', mustCall(() => onclose()));
proc.on('exit', mustCall((exitCode) => assert.strictEqual(exitCode, 0)));
proc.on('exit', mustCall((exitCode, signal) => assert.strictEqual(
exitCode,
0,
`exitCode: ${exitCode}, signal: ${signal}`)));
}
}

Expand Down

0 comments on commit 15b6bcf

Please sign in to comment.