-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
1. Rename private functions 2. Use destructuring 3. Remove obsolete comments PR-URL: #13862 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #14428 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Loading branch information
Showing
2 changed files
with
75 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,75 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| // no args | ||
| // No args | ||
| assert.throws( | ||
| () => { assert.fail(); }, | ||
| common.expectsError({ | ||
| code: 'ERR_ASSERTION', | ||
| type: assert.AssertionError, | ||
| operator: undefined, | ||
| actual: undefined, | ||
| expected: undefined, | ||
| message: 'undefined undefined undefined' | ||
| }) | ||
| ); | ||
|
|
||
| // one arg = message | ||
| // One arg = message | ||
| assert.throws( | ||
| () => { assert.fail('custom message'); }, | ||
| common.expectsError({ | ||
| code: 'ERR_ASSERTION', | ||
| type: assert.AssertionError, | ||
| operator: undefined, | ||
| actual: undefined, | ||
| expected: undefined, | ||
| message: 'custom message' | ||
| }) | ||
| ); | ||
|
|
||
| // two args only, operator defaults to '!=' | ||
| // Two args only, operator defaults to '!=' | ||
| assert.throws( | ||
| () => { assert.fail('first', 'second'); }, | ||
| common.expectsError({ | ||
| code: 'ERR_ASSERTION', | ||
| type: assert.AssertionError, | ||
| operator: '!=', | ||
| actual: 'first', | ||
| expected: 'second', | ||
| message: '\'first\' != \'second\'' | ||
| }) | ||
| ); | ||
|
|
||
| // three args | ||
| // Three args | ||
| assert.throws( | ||
| () => { assert.fail('ignored', 'ignored', 'another custom message'); }, | ||
| common.expectsError({ | ||
| code: 'ERR_ASSERTION', | ||
| type: assert.AssertionError, | ||
| operator: undefined, | ||
| actual: 'ignored', | ||
| expected: 'ignored', | ||
| message: 'another custom message' | ||
| }) | ||
| ); | ||
|
|
||
| // no third arg (but a fourth arg) | ||
| // No third arg (but a fourth arg) | ||
| assert.throws( | ||
| () => { assert.fail('first', 'second', undefined, 'operator'); }, | ||
| common.expectsError({ | ||
| code: 'ERR_ASSERTION', | ||
| type: assert.AssertionError, | ||
| operator: 'operator', | ||
| actual: 'first', | ||
| expected: 'second', | ||
| message: '\'first\' operator \'second\'' | ||
| }) | ||
| ); | ||
|
|
||
| // The stackFrameFunction should exclude the foo frame | ||
| assert.throws( | ||
| function foo() { assert.fail('first', 'second', 'message', '!==', foo); }, | ||
| (err) => !/foo/m.test(err.stack) | ||
| ); |