From 279d844fdae5ee3a9e74b9d6baa0623961bb0005 Mon Sep 17 00:00:00 2001 From: Mithun Sasidharan Date: Mon, 27 Nov 2017 16:33:26 +0530 Subject: [PATCH] test: refactored test-http-response-splitting to use countdown PR-URL: https://github.com/nodejs/node/pull/17348 Reviewed-By: Jon Moss Reviewed-By: Anna Henningsen Reviewed-By: Sakthipriyan Vairamani --- test/parallel/test-http-response-splitting.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-http-response-splitting.js b/test/parallel/test-http-response-splitting.js index b14d59e59ce8f9..88be1dfaf63fb0 100644 --- a/test/parallel/test-http-response-splitting.js +++ b/test/parallel/test-http-response-splitting.js @@ -5,6 +5,7 @@ const http = require('http'); const net = require('net'); const url = require('url'); const assert = require('assert'); +const Countdown = require('../common/countdown'); // Response splitting example, credit: Amit Klein, Safebreach const str = '/welcome?lang=bar%c4%8d%c4%8aContent­Length:%200%c4%8d%c4%8a%c' + @@ -18,6 +19,7 @@ const x = 'fooഊSet-Cookie: foo=barഊഊ'; const y = 'foo⠊Set-Cookie: foo=bar'; let count = 0; +const countdown = new Countdown(3, () => server.close()); function test(res, code, header) { assert.throws(() => { @@ -40,8 +42,7 @@ const server = http.createServer((req, res) => { default: assert.fail('should not get to here.'); } - if (count === 3) - server.close(); + countdown.dec(); res.end('ok'); }); server.listen(0, () => {