Skip to content

Commit

Permalink
doc: modernize and fix code examples in repl.md
Browse files Browse the repository at this point in the history
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
vsemozhetbyt committed Apr 26, 2017
1 parent 4241577 commit 35d2137
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions doc/api/readline.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ For example:

```js
rl.on('SIGINT', () => {
rl.question('Are you sure you want to exit?', (answer) => {
rl.question('Are you sure you want to exit? ', (answer) => {
if (answer.match(/^y(es)?$/i)) rl.pause();
});
});
Expand Down Expand Up @@ -255,7 +255,7 @@ If the `readline.Interface` was created with `output` set to `null` or
Example usage:

```js
rl.question('What is your favorite food?', (answer) => {
rl.question('What is your favorite food? ', (answer) => {
console.log(`Oh, so your favorite food is ${answer}`);
});
```
Expand Down Expand Up @@ -414,7 +414,7 @@ For instance: `[[substr1, substr2, ...], originalsubstring]`.
```js
function completer(line) {
const completions = '.help .error .exit .quit .q'.split(' ');
const hits = completions.filter((c) => c.indexOf(line) === 0);
const hits = completions.filter((c) => c.startsWith(line));
// show all completions if none found
return [hits.length ? hits : completions, line];
}
Expand Down

0 comments on commit 35d2137

Please sign in to comment.