Skip to content

Commit

Permalink
doc: add petkaantonov as collaborator
Browse files Browse the repository at this point in the history 
PR-URL: #1179
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig <cjihrig@gmail.com>
  • Loading branch information
@petkaantonov
petkaantonov committed Mar 17, 2015
1 parent 92c1ad9 commit 3c8ae2d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ information about the governance of the io.js project, see
* **Julian Duque** ([@julianduque](https://github.com/julianduque)) &lt;julianduquej@gmail.com&gt;
* **Johan Bergström** ([@jbergstroem](https://github.com/jbergstroem)) &lt;bugs@bergstroem.nu&gt;
* **Roman Reiss** ([@silverwind](https://github.com/silverwind)) &lt;me@silverwind.io&gt;
* **Petka Antonov** ([@petkaantonov](https://github.com/petkaanotnov)) &lt;petka_antonov@hotmail.com&gt;

Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
maintaining the io.js project.

7 comments on commit 3c8ae2d

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-By: cjihrig cjihrig@gmail.com

should be Reviewed-By: Colin Ihrig <cjihrig@gmail.com> :)

@petkaantonov
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted the git author field :P lol I knew I couldn't get it right

@silverwind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I handled it like this:

git log | grep username

And just took the last line there. Not totally error-prone though :)

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually want full names, so it should be pretty easy to spot.

@cjihrig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found better results with git log --grep="somestring" instead of git log | grep somestring.

@silverwind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with amend + force push for minor stuff like this?

@rvagg
Copy link
Member

@rvagg rvagg commented on 3c8ae2d Mar 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on amend and force push only if this is the top commit on the pile, otherwise it's gone and you should let it go

Please sign in to comment.