Skip to content

Commit

Permalink
test: remove unused vars
Browse files Browse the repository at this point in the history
Remove unused vars in tests

PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Conflicts:
	test/parallel/test-timers-throw-when-cb-not-function.js
  • Loading branch information
Trott authored and Fishrock123 committed Jan 6, 2016
1 parent 5be0259 commit 4b14f1c
Show file tree
Hide file tree
Showing 23 changed files with 23 additions and 44 deletions.
2 changes: 1 addition & 1 deletion test/addons/repl-domain-abort/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ var options = {
};

// Run commands from fake REPL.
var dummy = repl.start(options);
repl.start(options);
9 changes: 1 addition & 8 deletions test/debugger/test-debugger-pid.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
'use strict';
var common = require('../common');
require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;

var port = common.PORT + 1337;
var buffer = '';
var expected = [];
var scriptToDebug = common.fixturesDir + '/empty.js';

function fail() {
assert(0); // `--debug-brk script.js` should not quit
}

// connect to debug agent
var interfacer = spawn(process.execPath, ['debug', '-p', '655555']);
Expand Down
2 changes: 0 additions & 2 deletions test/debugger/test-debugger-remote.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ var common = require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;

var port = common.PORT + 1337;
var buffer = '';
var expected = [];
var scriptToDebug = common.fixturesDir + '/empty.js';

function fail() {
Expand Down
5 changes: 2 additions & 3 deletions test/internet/test-dns.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ require('../common');
var assert = require('assert'),
dns = require('dns'),
net = require('net'),
isIP = net.isIP,
isIPv4 = net.isIPv4,
isIPv6 = net.isIPv6;
var util = require('util');
Expand Down Expand Up @@ -48,7 +47,7 @@ TEST(function test_reverse_bogus(done) {
var error;

try {
var req = dns.reverse('bogus ip', function() {
dns.reverse('bogus ip', function() {
assert.ok(false);
});
} catch (e) {
Expand Down Expand Up @@ -369,7 +368,7 @@ console.log('looking up nodejs.org...');

var cares = process.binding('cares_wrap');
var req = new cares.GetAddrInfoReqWrap();
var err = cares.getaddrinfo(req, 'nodejs.org', 4);
cares.getaddrinfo(req, 'nodejs.org', 4);

req.oncomplete = function(err, domains) {
assert.strictEqual(err, 0);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-domain-exit-dispose-again.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// to that domain, including those whose callbacks are called from within
// the same invocation of listOnTimeout, _are_ called.

var common = require('../common');
require('../common');
var assert = require('assert');
var domain = require('domain');
var disposalFailed = false;
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-domain-implicit-fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
require('../common');
var assert = require('assert');
var domain = require('domain');
var events = require('events');
var caught = 0;
var expectCaught = 1;

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http-agent-error-on-idle.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function get(callback) {
return http.get(requestParams, callback);
}

var destroy_queue = {};
var server = http.createServer(function(req, res) {
res.end('hello world');
});
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-vm-create-context-arg.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ var assert = require('assert');
var vm = require('vm');

assert.throws(function() {
var ctx = vm.createContext('string is not supported');
vm.createContext('string is not supported');
}, TypeError);

assert.doesNotThrow(function() {
var ctx = vm.createContext({ a: 1 });
ctx = vm.createContext([0, 1, 2, 3]);
vm.createContext({ a: 1 });
vm.createContext([0, 1, 2, 3]);
});

assert.doesNotThrow(function() {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-vm-harmony-proxies.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ var vm = require('vm');
// src/node_contextify.cc filters out the Proxy object from the parent
// context. Make sure that the new context has a Proxy object of its own.
var sandbox = {};
var result = vm.runInNewContext('this.Proxy = Proxy', sandbox);
vm.runInNewContext('this.Proxy = Proxy', sandbox);
assert(typeof sandbox.Proxy === 'object');
assert(sandbox.Proxy !== Proxy);

// Unless we copy the Proxy object explicitly, of course.
var sandbox = { Proxy: Proxy };
var result = vm.runInNewContext('this.Proxy = Proxy', sandbox);
vm.runInNewContext('this.Proxy = Proxy', sandbox);
assert(typeof sandbox.Proxy === 'object');
assert(sandbox.Proxy === Proxy);
4 changes: 2 additions & 2 deletions test/parallel/test-vm-harmony-symbols.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ var vm = require('vm');

// The sandbox should have its own Symbol constructor.
var sandbox = {};
var result = vm.runInNewContext('this.Symbol = Symbol', sandbox);
vm.runInNewContext('this.Symbol = Symbol', sandbox);
assert(typeof sandbox.Symbol === 'function');
assert(sandbox.Symbol !== Symbol);

// Unless we copy the Symbol constructor explicitly, of course.
var sandbox = { Symbol: Symbol };
var result = vm.runInNewContext('this.Symbol = Symbol', sandbox);
vm.runInNewContext('this.Symbol = Symbol', sandbox);
assert(typeof sandbox.Symbol === 'function');
assert(sandbox.Symbol === Symbol);
3 changes: 2 additions & 1 deletion test/parallel/test-vm-new-script-new-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ assert.throws(function() {


console.error('undefined reference');
var error;
script = new Script('foo.bar = 5;');
assert.throws(function() {
script.runInNewContext();
Expand All @@ -41,7 +40,9 @@ code = 'foo = 1;' +
foo = 2;
obj = { foo: 0, baz: 3 };
script = new Script(code);
/* eslint-disable no-unused-vars */
var baz = script.runInNewContext(obj);
/* eslint-enable no-unused-vars */
assert.equal(1, obj.foo);
assert.equal(2, obj.bar);
assert.equal(2, foo);
Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-vm-run-in-new-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ code = 'foo = 1;' +
'if (baz !== 3) throw new Error(\'test fail\');';
foo = 2;
obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
var baz = vm.runInNewContext(code, obj);
/* eslint-enable no-unused-vars */
assert.equal(1, obj.foo);
assert.equal(2, obj.bar);
assert.equal(2, foo);
Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-vm-static-this.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ code = 'foo = 1;' +
'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
foo = 2;
obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
var baz = vm.runInThisContext(code);
/* eslint-enable no-unused-vars */
assert.equal(0, obj.foo);
assert.equal(2, bar);
assert.equal(1, foo);
Expand Down
1 change: 0 additions & 1 deletion test/pummel/test-dtrace-jsstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ var doogle = function() {
};

var spawn = require('child_process').spawn;
var prefix = '/var/tmp/node';

/*
* We're going to use DTrace to stop us, gcore us, and set us running again
Expand Down
1 change: 0 additions & 1 deletion test/pummel/test-fs-watch-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ var watchSeenTwo = 0;
var watchSeenThree = 0;
var watchSeenFour = 0;

var startDir = process.cwd();
var testDir = common.tmpDir;

var filenameOne = 'watch.txt';
Expand Down
3 changes: 0 additions & 3 deletions test/pummel/test-https-no-reader.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ var options = {
};

var buf = new Buffer(1024 * 1024);
var sent = 0;
var received = 0;

var server = https.createServer(options, function(req, res) {
res.writeHead(200);
Expand All @@ -30,7 +28,6 @@ var server = https.createServer(options, function(req, res) {
});

server.listen(common.PORT, function() {
var resumed = false;
var req = https.request({
method: 'POST',
port: common.PORT,
Expand Down
4 changes: 0 additions & 4 deletions test/pummel/test-regress-GH-892.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@ var https = require('https');

var fs = require('fs');

var PORT = 8000;


var bytesExpected = 1024 * 1024 * 32;
var gotResponse = false;

var started = false;

Expand Down
2 changes: 0 additions & 2 deletions test/pummel/test-stream2-basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ test('pipe', function(t) {
'xxxxx' ];

var w = new TestWriter();
var flush = true;

w.on('end', function(received) {
t.same(received, expect);
Expand Down Expand Up @@ -439,7 +438,6 @@ test('adding readable triggers data flow', function(t) {
r.push(new Buffer('asdf'));
};

var called = false;
r.on('readable', function() {
onReadable = true;
r.read();
Expand Down
6 changes: 3 additions & 3 deletions test/pummel/test-timers.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ function t() {
expectedTimeouts--;
}

var w = setTimeout(t, 200);
var x = setTimeout(t, 200);
setTimeout(t, 200);
setTimeout(t, 200);
var y = setTimeout(t, 200);

clearTimeout(y);
var z = setTimeout(t, 200);
setTimeout(t, 200);
clearTimeout(y);


Expand Down
1 change: 0 additions & 1 deletion test/pummel/test-watch-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ var fs = require('fs');
var path = require('path');

var f = path.join(common.fixturesDir, 'x.txt');
var f2 = path.join(common.fixturesDir, 'x2.txt');

console.log('watching for changes of ' + f);

Expand Down
2 changes: 0 additions & 2 deletions test/sequential/test-stream2-fs.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
var common = require('../common');
var R = require('_stream_readable');
var assert = require('assert');

var fs = require('fs');
Expand Down Expand Up @@ -41,7 +40,6 @@ var w = new TestWriter();
w.on('results', function(res) {
console.error(res, w.length);
assert.equal(w.length, size);
var l = 0;
assert.deepEqual(res.map(function(c) {
return c.length;
}), expectLengths);
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-tcp-wrap-listen.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ assert.equal(0, r);

server.listen(128);

var slice, sliceCount = 0, eofCount = 0;
var sliceCount = 0, eofCount = 0;

var writeCount = 0;
var recvCount = 0;
Expand Down
2 changes: 1 addition & 1 deletion test/timers/test-timers-reliability.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ monoTimer.ontimeout = function() {

monoTimer.start(300, 0);

var timer = setTimeout(function() {
setTimeout(function() {
timerFired = true;
}, 200);

Expand Down

0 comments on commit 4b14f1c

Please sign in to comment.