Skip to content

Commit

Permalink
process: make process.release.name "node"
Browse files Browse the repository at this point in the history
This commit sets the value of process.release.name to "node".

Fixes: #2361
PR-URL: #2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
cjihrig committed Aug 23, 2015
1 parent 45a2046 commit 4f50d3f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions doc/api/process.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,8 @@ for the source tarball and headers-only tarball.

`process.release` contains the following properties:

* `name`: a string with a value that will always be `"node.js"` for Node.js.
* `name`: a string with a value that will always be `"node"` for Node.js. For
legacy io.js releases, this will be `"io.js"`.
* `sourceUrl`: a complete URL pointing to a _.tar.gz_ file containing the
source of the current release.
* `headersUrl`: a complete URL pointing to a _.tar.gz_ file containing only
Expand All @@ -693,7 +694,7 @@ for the source tarball and headers-only tarball.

e.g.

{ name: 'node.js',
{ name: 'node',
sourceUrl: 'https://nodejs.org/download/release/v4.0.0/node-v4.0.0.tar.gz',
headersUrl: 'https://nodejs.org/download/release/v4.0.0/node-v4.0.0-headers.tar.gz',
libUrl: 'https://nodejs.org/download/release/v4.0.0/win-x64/node.lib' }
Expand Down
2 changes: 1 addition & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2768,7 +2768,7 @@ void SetupProcessObject(Environment* env,
// process.release
Local<Object> release = Object::New(env->isolate());
READONLY_PROPERTY(process, "release", release);
READONLY_PROPERTY(release, "name", OneByteString(env->isolate(), "node.js"));
READONLY_PROPERTY(release, "name", OneByteString(env->isolate(), "node"));

// if this is a release build and no explicit base has been set
// substitute the standard release download URL
Expand Down

0 comments on commit 4f50d3f

Please sign in to comment.