From 5209ff95628c438765327db8750a3bd9fd0d789f Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 23 May 2018 13:10:53 +0200 Subject: [PATCH] src: remove unused fields msg_ and env_ Currently the following compiler warnings are generated: ../src/node_messaging.cc:74:16: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ ../src/node_messaging.cc:75:12: warning: private field 'msg_' is not used [-Wunused-private-field] Message* msg_; ^ 2 warnings generated. This commit removes these unused private members. PR-URL: https://github.com/nodejs/node/pull/20876 Reviewed-By: Gireesh Punathil Reviewed-By: Benjamin Gruenbaum Reviewed-By: Shingo Inoue Reviewed-By: Matteo Collina Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: John-David Dalton Reviewed-By: Gus Caplan --- src/node_messaging.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/node_messaging.cc b/src/node_messaging.cc index ede38cc817bfbb..b56cef2d7767cf 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -47,9 +47,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate { const std::vector& message_ports, const std::vector>& shared_array_buffers) - : env_(env), - msg_(m), - message_ports_(message_ports), + : message_ports_(message_ports), shared_array_buffers_(shared_array_buffers) {} MaybeLocal ReadHostObject(Isolate* isolate) override { @@ -71,8 +69,6 @@ class DeserializerDelegate : public ValueDeserializer::Delegate { ValueDeserializer* deserializer = nullptr; private: - Environment* env_; - Message* msg_; const std::vector& message_ports_; const std::vector>& shared_array_buffers_; };