From 5350f04e428232ef4dfe147e61528949d1775d8e Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 10 Feb 2017 23:26:25 -0800 Subject: [PATCH] test: refactor test-repl-sigint * remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: https://github.com/nodejs/node/pull/11309 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Sakthipriyan Vairamani --- test/parallel/test-repl-sigint.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-repl-sigint.js b/test/parallel/test-repl-sigint.js index 5ee974aaea340e..61bc75cc6ffe67 100644 --- a/test/parallel/test-repl-sigint.js +++ b/test/parallel/test-repl-sigint.js @@ -17,18 +17,10 @@ const child = spawn(process.execPath, [ '-i' ], { let stdout = ''; child.stdout.setEncoding('utf8'); -child.stdout.pipe(process.stdout); child.stdout.on('data', function(c) { stdout += c; }); -child.stdin.write = ((original) => { - return (chunk) => { - process.stderr.write(chunk); - return original.call(child.stdin, chunk); - }; -})(child.stdin.write); - child.stdout.once('data', common.mustCall(() => { process.on('SIGUSR2', common.mustCall(() => { process.kill(child.pid, 'SIGINT'); @@ -45,6 +37,12 @@ child.stdout.once('data', common.mustCall(() => { child.on('close', function(code) { assert.strictEqual(code, 0); - assert.notStrictEqual(stdout.indexOf('Script execution interrupted.\n'), -1); - assert.notStrictEqual(stdout.indexOf('42042\n'), -1); + assert.ok( + stdout.includes('Script execution interrupted.\n'), + `Expected stdout to contain "Script execution interrupted.", got ${stdout}` + ); + assert.ok( + stdout.includes('42042\n'), + `Expected stdout to contain "42042", got ${stdout}` + ); });