From 5649174ddadece665ec8b96d200b1936a5c6e4f6 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 4 Feb 2017 11:05:26 +0100 Subject: [PATCH] doc: typographical fixes in COLLABORATOR_GUIDE.md Fix a typo and add a missing line break. PR-URL: https://github.com/nodejs/node/pull/11163 Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Nikolai Vavilov Reviewed-By: Joyee Cheung --- COLLABORATOR_GUIDE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index dd5bc4e8005ed2..4ce11257b707f2 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -122,7 +122,7 @@ followed to determine which aspects of the Node.js API are considered Exception to each of these points can be made if use or behavior of a given internal API can be demonstrated to be sufficiently relied upon by the Node.js -ecosystem such that any changes would cause too much breakage. The threshhold +ecosystem such that any changes would cause too much breakage. The threshold for what qualifies as "too much breakage" is to be decided on a case-by-case basis by the CTC. @@ -161,7 +161,8 @@ sufficient review by collaborators and approval of at least two CTC members. Examples of breaking changes include, but are not necessarily limited to, removal or redefinition of existing API arguments, changing return values -(except when return values do not currently exist), removing or modifying existing properties on an options argument, adding or removing errors, +(except when return values do not currently exist), removing or modifying +existing properties on an options argument, adding or removing errors, changing error messages in any way, altering expected timing of an event (e.g. moving from sync to async responses or vice versa), and changing the non-internal side effects of using a particular API.